Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEC-7] pin scipy version; remove support for python 3.8 #58

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

seedlit
Copy link
Contributor

@seedlit seedlit commented Sep 18, 2023

Jira ticket here
Scope: Dependabot discovered a potential vulnerability. This PR:

  • explicitly pins scipy version as a dependency (scipy is a sub-dependency of scikit-image, but it lists scipy>=1.8 as sub-dependency)
  • removes support for Python 3.8 (as it's not supported by latest scipy version)

@seedlit seedlit requested review from a team and DylanBartels September 18, 2023 14:59
@seedlit seedlit changed the title [] pin scipy version; remove support for python 3.8 [SEC-7] pin scipy version; remove support for python 3.8 Sep 18, 2023
Copy link

@Geosynopsis Geosynopsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please update the readme indicating the removal of python 3.8 support.

@seedlit
Copy link
Contributor Author

seedlit commented Sep 18, 2023

@Geosynopsis I already updated the Installation section..
Did I miss anything?

@seedlit seedlit merged commit d8c523e into master Sep 19, 2023
9 checks passed
@seedlit seedlit deleted the bump_scipy_version branch September 19, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants